Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ Benchmark search #2141

Closed
wants to merge 18 commits into from
Closed

⚗️ Benchmark search #2141

wants to merge 18 commits into from

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Nov 7, 2024

Benchmark this PR #2135

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (57fbd29) to head (f4cbf1f).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2141      +/-   ##
==========================================
+ Coverage   92.53%   92.63%   +0.10%     
==========================================
  Files          55       55              
  Lines        6467     6507      +40     
==========================================
+ Hits         5984     6028      +44     
+ Misses        483      479       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 7, 2024

@github-actions github-actions bot temporarily deployed to pull request November 7, 2024 12:50 Inactive
@Koncopd Koncopd mentioned this pull request Nov 7, 2024
@sunnyosun
Copy link
Member

Shall we eventually move the benchmarking notebook into lamin-dev?

@sunnyosun sunnyosun linked an issue Nov 7, 2024 that may be closed by this pull request
@Koncopd
Copy link
Member Author

Koncopd commented Nov 7, 2024

Yes, probably.

@github-actions github-actions bot temporarily deployed to pull request November 7, 2024 17:17 Inactive
@falexwolf falexwolf changed the title ⚗️ Benchmark (improved) lamindb and bionty search ⚗️ Benchmark search Nov 8, 2024
@Koncopd Koncopd closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search is much better on the UI than in the open-source package
2 participants