-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚸 Automatically refresh user tokens #145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no handle is provided it will now attempt to get one from the user setting file
Previously it could be set without successfully connecting
Forces the function to ignore cached user settings
Check if the request failed due to an invalid token and if so call lamin_login() to refresh the token and make a new request with updated he headers
When there is no user settings file an anonymous user is returned from .get_user_settings() rather than an error
rcannood
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, otherwise LGTM!
Co-authored-by: Robrecht Cannoodt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Automatically refresh user tokens when trying to connect to an instance with an invalid token instead of failing with an error message:
lamin_login()
to use a stored user handle when none is suppliedcreate_instance()
so that it isn't set before a successful connectionrefresh
argument to.get_user_settings()
to force ignoring the cacheapi$get_schema()
due to an invalid token and if so calllamin_login()
to refresh the token and make a new request with updated he headers
Checklist
Before review
Before merge
README
CHANGELOG