Make jvmInterruptible public
#73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
reviewed
May 14, 2024
| * operations such as `.await`) *and* [[java.lang.InterruptedException]], so the intended use case is usually to wrap | ||
| * interruptible Java operations, containing `fn` to a narrow scope. | ||
| */ | ||
| def jvmInterruptible[T](fn: => T)(using Async): T = |
There was a problem hiding this comment.
as this method is alread inside the JvmAsyncOperations, why it's not been named interruptible?
on unsupported platform, which can be just a noop.
There was a problem hiding this comment.
We already don't compile this function on an unsupported platform. I usually don't like the idea that we expose a function that sounds like it does something but is actually a no-op underneath 😓
We could call this function interruptible since it's already under JvmAsyncOperations, but I think it might be confused with the uninterruptible function that we do have outside.
They also take the same argument types, to add to the fire :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71. Also added some documentation.