chore: upgrade datafusion and arrow-rs #1390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
commented
Oct 11, 2023
| @@ -1528,22 +1529,22 @@ mod tests { | |||
|
|
|||
| let arr = read_array_w_params(&reader, &schema.fields[1], ReadBatchParams::RangeFull).await; | |||
| assert_eq!(100, arr.len()); | |||
| assert_eq!(100, arr.null_count()); | |||
| assert_eq!(arr.data_type(), &DataType::Null); | |||
There was a problem hiding this comment.
null_count() no longer returns the logical null count, just the number of "physical nulls". apache/arrow-rs#4691
eddyxu
reviewed
Oct 11, 2023
| arrow-schema = "43.0" | ||
| arrow-select = "43.0" | ||
| arrow = { version = "46.0.0", optional = false } | ||
| arrow-arith = "46.0" |
There was a problem hiding this comment.
IIRC, we are wait for arrow 47 for a few fixes? And datafusion 32 is being voted at the moment, right?
There was a problem hiding this comment.
Why wait? Is something broken in 46?
There was a problem hiding this comment.
Do we need to bump datafusion again in 3-5 days to include fixes?
There was a problem hiding this comment.
🤷 yes, we need to upgrade for the next version. IMO we should upgrade on every datafusion release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.