Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Lance storage options #2830

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wjones127
Copy link
Contributor

@github-actions github-actions bot added the enhancement New feature or request label Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 77.86%. Comparing base (99f554f) to head (dae5d22).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-io/src/object_store/options.rs 0.00% 50 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2830      +/-   ##
==========================================
- Coverage   78.47%   77.86%   -0.62%     
==========================================
  Files         229      230       +1     
  Lines       69488    70156     +668     
  Branches    69488    70156     +668     
==========================================
+ Hits        54533    54628      +95     
- Misses      11866    12436     +570     
- Partials     3089     3092       +3     
Flag Coverage Δ
unittests 77.86% <0.00%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants