-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove used_coding as it is not used currently #3081
chore: remove used_coding as it is not used currently #3081
Conversation
… when we needed. I like writing code and I like deleting code even more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3081 +/- ##
==========================================
+ Coverage 77.87% 77.92% +0.05%
==========================================
Files 240 240
Lines 81630 81564 -66
Branches 81630 81564 -66
==========================================
- Hits 63566 63559 -7
+ Misses 14830 14810 -20
+ Partials 3234 3195 -39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up.
Not a rush, but we might want to consider adding data block constructors (e.g. new
) at some point so that something like...
FixedWidthDataBlock {
bits_per_value: self.bytes_per_value * 8,
data,
num_values,
block_info: BlockInfo::new(),
used_encoding: UsedEncoding::new()
}
Can become...
FixedWidthDataBlock::new(self.bytes_per_value * 8, data, num_values)
Then we can hide any default / newly-initialized fields (e.g. block_info
).
1adecd0
to
38c2445
Compare
remove used_coding as it is not used currently, we can add it back when we needed.