Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove used_coding as it is not used currently #3081

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

broccoliSpicy
Copy link
Contributor

@broccoliSpicy broccoliSpicy commented Nov 3, 2024

remove used_coding as it is not used currently, we can add it back when we needed.

… when we needed.

I like writing code and I like deleting code even more.
@github-actions github-actions bot added the chore label Nov 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.92%. Comparing base (f60283e) to head (41f4e93).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3081      +/-   ##
==========================================
+ Coverage   77.87%   77.92%   +0.05%     
==========================================
  Files         240      240              
  Lines       81630    81564      -66     
  Branches    81630    81564      -66     
==========================================
- Hits        63566    63559       -7     
+ Misses      14830    14810      -20     
+ Partials     3234     3195      -39     
Flag Coverage Δ
unittests 77.92% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up.

Not a rush, but we might want to consider adding data block constructors (e.g. new) at some point so that something like...

FixedWidthDataBlock {
    bits_per_value: self.bytes_per_value * 8,
    data,
    num_values,
    block_info: BlockInfo::new(),
    used_encoding: UsedEncoding::new()
}

Can become...

FixedWidthDataBlock::new(self.bytes_per_value * 8, data, num_values)

Then we can hide any default / newly-initialized fields (e.g. block_info).

@broccoliSpicy broccoliSpicy merged commit f257489 into lancedb:main Nov 14, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants