refactor: remove the queue in LanceArrowWriter to reduce memory usage for spark sink #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaintBacchus
force-pushed
the
SparkSink
branch
from
520a7da
to
fe64c68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the queue in LanceArrowWriter since it may cache all rows in queue and that will require a lot of jvm memory.
Use mutex to control the write rate of sinker. Writer will wait util the reader take the batch.
And more I had moved the
maven-shade-plugininto a new profile which is diabled by default becausejar-with-dependenciewas conflict with many jars in spark dependencie