Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add expect_stat, expect_single_stat in GetStat trait #3126

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

broccoliSpicy
Copy link
Contributor

This PR tries to add helper function expect_stat and expect_single_stat to make DataBlock statistics easier to use.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.25837% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.92%. Comparing base (f257489) to head (9e8784f).

Files with missing lines Patch % Lines
rust/lance-encoding/src/statistics.rs 94.08% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3126    +/-   ##
========================================
  Coverage   77.91%   77.92%            
========================================
  Files         240      240            
  Lines       81564    81336   -228     
  Branches    81564    81336   -228     
========================================
- Hits        63550    63379   -171     
+ Misses      14806    14748    -58     
- Partials     3208     3209     +1     
Flag Coverage Δ
unittests 77.92% <94.25%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants