Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extglob rather than regex match operator. #347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jfgoog
Copy link
Contributor

@jfgoog jfgoog commented May 23, 2022

Not all shells support =~. Android, for example, uses mksh, which does
not.

Change is from suggestion at http://www.mirbsd.org/mksh-faq.htm#regex-comparison

Not all shells support =~. Android, for example, uses mksh, which does
not.

Change is from suggestion at http://www.mirbsd.org/mksh-faq.htm#regex-comparison
@landley
Copy link
Owner

landley commented Oct 25, 2022

They're not the same thing, would break sh.test "sh functions need block" test for example (looking for [Ss]yntax).

I replaced it with a call to grep -q in commit 1c74121

Hello github, I pushed the commit and edited to resave the message, please turn commit 1c74121 into a link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants