Skip to content

Add Redis 8 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## {{ UNRELEASED_VERSION }} - [{{ UNRELEASED_DATE }}]({{ UNRELEASED_LINK }})

* Added Redis 8
* Fix Leia testing

## v1.2.3 - [December 6, 2024](https://github.com/lando/redis/releases/tag/v1.2.3)

* Updated the version index.md to get Docuverse page to build correctly.
Expand Down
2 changes: 1 addition & 1 deletion builders/redis.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module.exports = {
name: 'redis',
config: {
version: '5',
supported: ['7', '7.0', '6', '6.0', '5', '5.0', '4', '4.0', '2.8'],
supported: ['8', '8.0', '7', '7.0', '6', '6.0', '5', '5.0', '4', '4.0', '2.8'],
patchesSupported: true,
confSrc: path.join(__dirname, '..', 'config'),
persist: false,
Expand Down
1 change: 1 addition & 0 deletions examples/8.x/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.log
14 changes: 14 additions & 0 deletions examples/8.x/.lando.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: lando-redis-8
services:
defaults:
type: redis:8
patch:
type: redis:8.0.1
password:
type: redis:8
password: nerfherder

# This is important because it lets lando know to test against the plugin in this repo
# DO NOT REMOVE THIS!
plugins:
"@lando/redis": ./../../
50 changes: 50 additions & 0 deletions examples/8.x/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
Redis Example
=============

This example exists primarily to test the following documentation:

* [Redis Service](https://docs.devwithlando.io/tutorials/redis.html)

Start up tests
--------------

Run the following commands to get up and running with this example.

```bash
# Should start up successfully
lando poweroff
lando start
```

Verification commands
---------------------

Run the following commands to validate things are rolling as they should.

```bash
# Should use 8.x as the default version
lando ssh -s defaults -c "redis-server --version | grep v=8."

# Should be able to connect to redis
lando ssh -s defaults -c "redis-cli CONFIG GET databases"

# Should be able to connect to redis w/password
lando ssh -s password -c "redis-cli --pass nerfherder CONFIG GET databases"

# Should use the user specifiec patch version if given
lando ssh -s patch -c "redis-server --version | grep v=8.0.1"

# Should include the redis-cli
lando ssh -s defaults -c "redis-cli --version"
```

Destroy tests
-------------

Run the following commands to trash this app like nothing ever happened.

```bash
# Should be destroyed with success
lando destroy -y
lando poweroff
```
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"docs:preview": "vitepress preview docs",
"lint": "eslint . --ext .js --ext .mjs ",
"test:unit": "nyc --reporter=html --reporter=text mocha --timeout 5000 test/**/*.spec.js",
"test:leia": "npm run leia \"examples/**/README.md\" -c 'Destroy tests' --stdin",
"test:leia": "leia \"examples/**/README.md\" -c 'Destroy tests' --stdin",
"test": "npm run lint && npm run test:unit"
},
"dependencies": {
Expand Down