Upgrade v3 #4
Open
Upgrade v3 #4
+2,948
−1,243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @landrok,
Yousign has now a new v3 API so I updated the package to be compatible with it.
While v2 is maintained by Yousign, I updated keeping v2 backward compatibility in order to propose a full Yousign API wrapper so everyone can use it regardless they are on v2 or on v3. Only one change is necessary for package user after this update :
use Yousign\Api\YousignApi;=>use Yousign\Api\V2\YousignApi;I kept the original architecture of the package, only splitting into v2 and v3 sub-folders for Api, Model and tests.
I updated the README to be more specific to v3, because new users will mostly be v3 users, but I didn't update the full documentation. I wasn't able to make sphinx work on my machine tbh. I will write it down later if you ok with the PR.