test(genai): add test for ChatGoogleGenerativeAI class transport check
#831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkuligin
reviewed
Apr 2, 2025
| model = ChatGoogleGenerativeAI(model=_MODEL, transport="rest") | ||
| assert model.client.transport.kind == "rest" | ||
|
|
||
| async def check_async_client(): |
There was a problem hiding this comment.
why should this be async function?
There was a problem hiding this comment.
model.async_client does not appear to exist if ChatGoogleGenerativeAI is called outside of an async function
There was a problem hiding this comment.
So if this is added before the async function:
model = ChatGoogleGenerativeAI(model=_MODEL)
print(model.async_client)
print(model.client)
assert model.async_client.transport.kind == "grpc_asyncio"
then the test results look like this:
|
@imperorrp sorry for delay but can you please resolve conflicts? Otherwise if this is solved can we close? |
mdrxy
changed the title
ChatGoogleGenerativeAI class transport check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Added a test for PR #822 for parity with the VertexAI transport check test at https://github.com/imperorrp/langchain-google/blob/main/libs/vertexai/tests/integration_tests/test_chat_models.py#L788-L803
Relevant issues
#791
Type
✅ Test
Testing