Model features : json mode #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattf
requested changes
Oct 18, 2024
There was a problem hiding this comment.
@raspawar it is great that users can bind() to use json mode. in addition, the structured output needs to support this, see https://python.langchain.com/docs/how_to/structured_output/#advanced-specifying-the-method-for-structuring-outputs and https://github.com/langchain-ai/langchain-nvidia/blob/main/libs/ai-endpoints/langchain_nvidia_ai_endpoints/chat_models.py#L776
mattf
reviewed
Nov 13, 2024
| @@ -647,8 +672,11 @@ def bind_functions( | |||
| # as a result need to type ignore for the schema parameter and return type. | |||
| def with_structured_output( # type: ignore | |||
| self, | |||
| schema: Union[Dict, Type], | |||
| schema: Optional[Union[Dict, Type]] = None, | |||
There was a problem hiding this comment.
the base class' signature does not let schema=None. why make this change?
mattf
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Json Mode:
Validated the json mode support models.
~18 models from API catalogue support json mode.
Example usage in Notebook and test cases for json mode support.
cc: @sumitkbh