Skip to content

deps: add missing dependencies in test group #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nazarpechka
Copy link

This PR adds missing dependencies to pyproject.toml test dependency group (used for local development).
Added dependencies:

ValueError: the greenlet library is required to use this function. No module named 'greenlet'

pyproject.toml Outdated
@@ -22,6 +22,8 @@ dependencies = [

[dependency-groups]
test = [
"codespell>=2.4.1",
"greenlet>=3.2.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of installing greenlet directly, I believe we can update sqlalchemy to SQLAlchemy[asyncio].

Copy link
Author

@nazarpechka nazarpechka Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@averikitsch Thanks, updated to sqlalchemy[asyncio].
This is a library dependency, so we will force all users to also install greenlet. This should not be a problem though, as using AsyncPgVectorStore needs it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants