Metadata json filtering #261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to default port used in tests
|
Can we add documentation related to this PR into https://github.com/langchain-ai/langchain-postgres/blob/main/examples/pg_vectorstore_how_to.ipynb ? |
@dishaprakash done |
averikitsch
reviewed
Oct 31, 2025
| -e POSTGRES_PASSWORD=langchain \ | ||
| -e POSTGRES_DB=langchain_test \ | ||
| -p 6024:5432 pgvector/pgvector:pg16 \ | ||
| -p 5432:5432 pgvector/pgvector:pg16 \ |
There was a problem hiding this comment.
Suggested change
| -p 5432:5432 pgvector/pgvector:pg16 \ | |
| -p 6024:5432 pgvector/pgvector:pg16 \ |
averikitsch
reviewed
Oct 31, 2025
| Document( | ||
| page_content=texts[i], | ||
| metadata=( | ||
| METADATAS[i] | {f"{key}_json": value for key, value in METADATAS[i].items()} |
There was a problem hiding this comment.
Instead of adding more metadata to each doc, can we make a special test case to test this?
averikitsch
reviewed
Oct 31, 2025
| bool: "BOOLEAN", | ||
| datetime.date: "DATE", | ||
| datetime.datetime: "TIMESTAMP", | ||
| datetime.time: "TIME", |
There was a problem hiding this comment.
We may need to convert Python None to Null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249