Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard-tests: model param test #29595

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

efriis
Copy link
Member

@efriis efriis commented Feb 5, 2025

features that depend on initialization with model=:

  • standard interface documented as a "standard parameter"
  • (optional/nice to have): standard model param for init_chat_model (alternatively could initialize elsewhere)

features that depend on accessing model by .model:

  • default populating of ls_params["ls_model_name"], which langsmith uses for token cost lookup etc (note currently there's a backup of model_name too but it's only those 2)

notes:

  • I think it's ok to support this in addition to "more relevant" things like deployment_name on e.g. AzureChatOpenAI - this should still be configurable in addition to if you want to get token cost tracking

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 2:21am

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 5, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

1 participant