Skip to content

Conversation

bkaiserinfosec
Copy link

This is a fix for the GitHub Advanced Security (CodeQL) High severity finding for "Use of a broken or weak cryptographic hashing algorithm on sensitive data".

Screenshot 2025-10-09 042314

bkaiserinfosec and others added 2 commits October 9, 2025 03:40
… cryptographic hashing algorithm on sensitive data

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Potential fix for code scanning alert no. 11: Use of a broken or weak cryptographic hashing algorithm on sensitive data
@github-actions github-actions bot added core Related to the package `langchain-core` fix labels Oct 9, 2025
Copy link

codspeed-hq bot commented Oct 9, 2025

CodSpeed Performance Report

Merging #33383 will degrade performances by 21.21%

Comparing SecurityUniversalOrg:master (2c3f191) with master (b5030ba)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 5 regressions
✅ 8 untouched
⏩ 21 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
WallTime test_async_callbacks_in_sync 19.4 ms 24.6 ms -21.21%
WallTime test_import_time[ChatPromptTemplate] 501.3 ms 573.9 ms -12.65%
WallTime test_import_time[InMemoryVectorStore] 535.9 ms 596 ms -10.07%
WallTime test_import_time[LangChainTracer] 370.7 ms 412.5 ms -10.13%
WallTime test_import_time[PydanticOutputParser] 447 ms 510.8 ms -12.5%

Footnotes

  1. 21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@eyurtsev
Copy link
Collaborator

@bkaiserinfosec have you read the current implementation in the code together with the documentation before making this PR?

@eyurtsev eyurtsev closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Related to the package `langchain-core` fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants