feat(core): automatically count and store meta for tool call count #33756
Conversation
CodSpeed Performance ReportMerging #33756 will not alter performanceComparing
|
| def _store_tool_call_metadata(self, run: Run) -> None: | ||
| """Store tool call count in run metadata automatically.""" | ||
| try: | ||
| # Avoid circular imports |
There was a problem hiding this comment.
Utils doesn't import from base, so this shouldn't be needed right?
| def _persist_run(self, run: Run) -> None: | ||
| """Persist a run.""" | ||
|
|
||
| def _store_tool_call_metadata(self, run: Run) -> None: |
There was a problem hiding this comment.
I'd put this all in _complete_llm_run in tracers/core. We don't need to do this on all runs IMO
| Returns: | ||
| The tool call count if stored in metadata, otherwise `None`. | ||
| """ | ||
| extra = getattr(run, "extra", {}) or {} |
There was a problem hiding this comment.
Unnecessarily defensive right?
proof of concept