Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,12 @@ def before_model(self, state: AgentState, runtime: Runtime) -> dict[str, Any] |
messages = state["messages"]
self._ensure_message_ids(messages)

# If max_tokens_before_summary is None, summarization is disabled
if self.max_tokens_before_summary is None:
return None

total_tokens = self.token_counter(messages)
if (
self.max_tokens_before_summary is not None
and total_tokens < self.max_tokens_before_summary
):
if total_tokens < self.max_tokens_before_summary:
return None

cutoff_index = self._find_safe_cutoff(messages)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1056,12 +1056,18 @@ def test_summarization_middleware_no_summarization_cases() -> None:
model = FakeToolCallingModel()
middleware = SummarizationMiddleware(model=model, max_tokens_before_summary=1000)

# Test when summarization is disabled
# Test when summarization is disabled with few messages
middleware_disabled = SummarizationMiddleware(model=model, max_tokens_before_summary=None)
state = {"messages": [HumanMessage(content="Hello"), AIMessage(content="Hi")]}
result = middleware_disabled.before_model(state, None)
assert result is None

# Test when summarization is disabled with many messages (exceeding messages_to_keep)
many_messages = [HumanMessage(content=f"Message {i}") for i in range(25)]
state_many = {"messages": many_messages}
result = middleware_disabled.before_model(state_many, None)
assert result is None

# Test when token count is below threshold
def mock_token_counter(messages):
return 500 # Below threshold
Expand Down
Loading