Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci[patch]: Adds npm install test for conflicting deps #5895

Merged
merged 3 commits into from
Jun 25, 2024
Merged

ci[patch]: Adds npm install test for conflicting deps #5895

merged 3 commits into from
Jun 25, 2024

Conversation

jacoblee93
Copy link
Collaborator

npm has rather severe peer dependency resolution requirements, this will verify that we are not violating any of them.

CC @bracesproul

@vercel Vercel
Copy link

vercel bot commented Jun 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 6:47pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 6:47pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Jun 25, 2024
bracesproul
bracesproul approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'm assuming you've tested locally since this won't run in this PR

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jun 25, 2024
@jacoblee93
Copy link
Collaborator Author

lgtm, I'm assuming you've tested locally since this won't run in this PR

Hah, fixed. I want this to run on every PR.

@jacoblee93 jacoblee93 merged commit 9bd8199 into main Jun 25, 2024
26 checks passed
@jacoblee93 jacoblee93 deleted the jacob/ci branch June 25, 2024 18:48
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 4, 2024
Merged
This was referenced Jul 17, 2024
Open
Open
@Skrishnan586 Skrishnan586 mentioned this pull request Jul 22, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Jul 24, 2024
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacoblee93 @bracesproul