feat: adding azion edgesql integration to langchain-community #7344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
auto:documentation
jacoblee93
reviewed
Jan 2, 2025
| @@ -0,0 +1,53 @@ | |||
| ### Azion Edge SQL Retriever | |||
There was a problem hiding this comment.
Can we have this use the standard retriever template?
| @@ -0,0 +1,39 @@ | |||
| ### Azion Edge SQL Vector Store | |||
There was a problem hiding this comment.
You should also need to add azion/sql to peer and dev deps as shown here:
| const similarityQuery = ` | ||
| SELECT id, content, ${metadata.replace('hybrid', 'similarity')} | ||
| FROM ${this.vectorTable} | ||
| WHERE rowid IN vector_top_k('${this.vectorTable}_idx', vector('[${embeddedQuery}]'), ${rowsNumber}) ${filters} |
There was a problem hiding this comment.
Should we sanitize this better?
| message: string; | ||
| operation: string;} | undefined | ||
| ): Promise<[Document][]> { | ||
| return Promise.resolve([ |
There was a problem hiding this comment.
Let's just throw in this case
| * - "hybrid": Both vector and full-text search capabilities | ||
| * @returns {Promise<AzionVectorStore>} A promise that resolves with the configured vector store instance | ||
| */ | ||
| static async createVectorStore( |
There was a problem hiding this comment.
By convention have been calling async constructor methods .initialize
| * - metadataItems: Optional metadata fields to include in the results | ||
| * @returns A promise that resolves with the full-text search results when the search is complete. | ||
| */ | ||
| async AzionFullTextSearch( |
There was a problem hiding this comment.
Lower case for convention (also below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrations added: