fix(trimmer): trim last message when allowPartial: true
and strategy: first
#8287
+65
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team! 👋
While consuming the
trimMessages
abstraction, I've noticed that for the following example:The
trimmedMessages
would always strip away theHumanMessage
completely – even thoughallowPartial
istrue
, and we provided atextSplitter
which splits text into small chunks.Looking at the
_firstMaxTokens
code plus the equivalent Python algorithm, I saw a discrepancy in the way we're iterating. This PR fixes the issue by just navigating the entire array (including the last message).