chore: Replace deprecated modelName parameter with model parameter
#8325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
size:L
christian-bromann
changed the title
modelName parameter with model parameter
dosubot
bot
added
auto:documentation
christian-bromann
force-pushed
the
cb/model-modelname
branch
from
ce408a3 to
e740b18
Compare
This commit updates all instances of the deprecated `modelName` parameter to use the standardized `model` parameter across the langchain-openai package. It improves API consistency and follows the standard naming convention used across the LangChain ecosystem. The `modelName` parameter remains supported but is now marked as deprecated.
christian-bromann
force-pushed
the
cb/model-modelname
branch
from
e740b18 to
7438a80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation: Replace
modelNamewithmodelparameter across code baseThis PR replaces the deprecated
modelNameparameter with the preferredmodelparameter throughout the entire code base. This change standardizes the parameter naming and aligns with the current API conventions.Apologies for the large changeset - while this PR contains many file modifications, they all follow the same consistent pattern of replacing
modelName: "..."withmodel: "...". The changes are mechanical and do not alter any functionality.Changes Made:
libs/langchain-openai/src/tests/to usemodelinstead ofmodelNamemodelNameparameter still works)All changes maintain the same functionality while using the preferred parameter name. The deprecated
modelNameparameter continues to work for backward compatibility.If preferred, I'm happy to close this commit and break it down into smaller, more focused PRs covering specific test categories or libraries. This would make the review process more manageable if that would be helpful.