Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prompts): export client types #435

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Oct 21, 2024

Important

Add export for LangfusePromptClient, ChatPromptClient, and TextPromptClient in langfuse.ts.

  • Exports:
    • Add export for LangfusePromptClient, ChatPromptClient, and TextPromptClient from langfuse-core in langfuse.ts.

This description was created by Ellipsis for daca748. It will automatically update as commits are pushed.

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langfuse-js ✅ Ready (Inspect) Visit Preview Oct 21, 2024 1:19pm

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to daca748 in 6 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. langfuse/src/langfuse.ts:13
  • Draft comment:
    Consider adding a comment explaining why these types are being exported, for better code clarity.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The PR adds export statements for types from 'langfuse-core'.

Workflow ID: wflow_y1AsJBtfBuP6bF28


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@hassiebp hassiebp enabled auto-merge (squash) October 21, 2024 13:18
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: Experimental PR review

PR Summary

This pull request adds exports for prompt client types from the langfuse-core package to the main langfuse package, enhancing type support for users working with prompts.

  • Added exports for LangfusePromptClient, ChatPromptClient, and TextPromptClient types in langfuse/src/langfuse.ts
  • Ensures consistency with existing export patterns in the file
  • Improves type availability for users of the langfuse package when working with prompts

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@hassiebp hassiebp merged commit 037d515 into main Oct 21, 2024
9 checks passed
@hassiebp hassiebp deleted the hassieb/lfe-2544-export-PromptClients branch October 21, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ChatPromptClient type is not exported from js sdk
1 participant