chore(media): azure support #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
Added Azure Blob Storage support by including the required 'x-ms-blob-type: BlockBlob' header in media upload requests within the core package.
- Added 'x-ms-blob-type: BlockBlob' header in
processMediaItemmethod in/langfuse-core/src/index.tsfor Azure Blob Storage compatibility - Change maintains backward compatibility with existing storage backends while enabling Azure support
- Implementation follows Azure Blob Storage API requirements for blob uploads
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
No major changes found since last review. The previous review already covered the key aspects of adding Azure Blob Storage support through the 'x-ms-blob-type' header modification in the processMediaItem method.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
x-ms-blob-type: BlockBlobheader inLangfuseCoreStatelessto support Azure Blob Storage.x-ms-blob-type: BlockBlobheader inLangfuseCoreStatelessclass to support Azure Blob Storage uploads.This description was created by
for 6aafb8c. It will automatically update as commits are pushed.