-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix ci to run on v3 docker compose langfuse server from main branch #475
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
Updates CI workflow to use the standard docker-compose.yml instead of docker-compose.v3preview.yml for running Langfuse server in integration tests.
- Modified
.github/workflows/ci.yml
to remove v3preview configuration, indicating v3 features are now stable - Added timeout limits (3 mins for tests, 10 mins for integration tests) to prevent long-running CI jobs
- Added Node 18 and 20 matrix testing strategy for broader version compatibility
💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Updates CI workflow to use the stable Docker Compose configuration for Langfuse server, removing the v3preview version and improving health check monitoring.
- Added health check step in
.github/workflows/ci.yml
with 10 retries and 5-second intervals to ensure server availability - Added container logs output on health check failure for better debugging
- Simplified server startup by consolidating environment variables into a single docker compose command
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Updates CI workflow to use a more streamlined Docker Compose configuration for the Langfuse server, focusing on stability and simplified environment setup.
- Added
REDIS_HOST=""
to explicitly disable Redis in server configuration - Simplified environment variables by removing ClickHouse cluster settings and async processing flags
- Added health check step with 10 retries and 5-second intervals to verify server availability
- Added container logs output on health check failure for better debugging
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Added environment variable to ensure consistent data storage configuration in CI tests, focusing on Postgres-only operation.
- Added
LANGFUSE_RETURN_FROM_CLICKHOUSE=false
in.github/workflows/ci.yml
to enforce Postgres data retrieval during testing
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Based on the latest changes to the CI workflow, here's a concise summary of the most recent updates:
Updates CI workflow to use Postgres as the primary data store for testing, with improved environment configuration and health monitoring.
- Added
LANGFUSE_READ_FROM_POSTGRES_ONLY=true
andLANGFUSE_READ_FROM_CLICKHOUSE_ONLY=false
to ensure consistent data storage - Added
LANGFUSE_SDK_CI_SYNC_PROCESSING_ENABLED=true
for synchronous processing during tests - Improved health check monitoring with retry mechanism and detailed logging
- Removed deprecated ClickHouse and Redis configurations for simplified setup
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Important
Update CI workflow to use stable Docker Compose file for Langfuse server.
.github/workflows/ci.yml
to usedocker-compose.yml
instead ofdocker-compose.v3preview.yml
for running and logging the Langfuse server.This description was created by for b9ac219. It will automatically update as commits are pushed.