Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): unquarantine media download test #481

Merged
merged 2 commits into from
Dec 12, 2024
Merged

chore(ci): unquarantine media download test #481

merged 2 commits into from
Dec 12, 2024

Conversation

hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Dec 12, 2024

Important

Unquarantines a media reference test and updates CI configuration for LANGFUSE_S3_EVENT_UPLOAD_ENDPOINT.

  • Tests:
    • Unquarantines the test replace media reference string in object in langfuse-integration-fetch.spec.ts by removing .skip.
  • CI Configuration:
    • Changes LANGFUSE_S3_EVENT_UPLOAD_ENDPOINT from http://host.docker.internal:9090 to http://0.0.0.0:9090 in ci.yml.

This description was created by Ellipsis for 5bf0271. It will automatically update as commits are pushed.

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langfuse-js ✅ Ready (Inspect) Visit Preview Dec 12, 2024 9:52am

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: Experimental PR review

PR Summary

This PR enables media download testing in the integration suite by fixing networking configuration and unquarantining a previously skipped test case.

  • Changed S3 event upload endpoint from host.docker.internal:9090 to 0.0.0.0:9090 in CI workflow to fix container networking
  • Added test case for media reference string replacement that verifies audio file handling through base64 encoding/decoding
  • Test validates proper media reference format and consistent handling across multiple traces
  • Ensures media references maintain data integrity when stored and retrieved from traces

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: Experimental PR review

PR Summary

(updates since last review)

Updates CI configuration to use localhost:9090 instead of 0.0.0.0:9090 for the S3 media upload endpoint and adds health check verification for the Langfuse server.

  • Added detailed health check step in CI workflow to verify server availability before running tests
  • Changed LANGFUSE_S3_MEDIA_UPLOAD_ENDPOINT to use localhost:9090 for more reliable container networking
  • Added retry logic with max 10 attempts and 5-second intervals for server health verification
  • Added container logs output on health check failure for better debugging

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@hassiebp hassiebp merged commit 21f8676 into main Dec 12, 2024
9 checks passed
@hassiebp hassiebp deleted the fix-ci-minio branch December 12, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant