feat: migrate to batch ingestion endpoint #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
2 integration tests failing because this test takes the latest main docker server and is not able to cope with the new usage format. Succeeds locally. |
maxdeichmann
commented
Dec 13, 2023
| @@ -93,7 +104,7 @@ abstract class LangfuseCoreStateless { | |||
| this.publicKey = publicKey; | |||
| this.secretKey = secretKey; | |||
| this.baseUrl = removeTrailingSlash(options?.baseUrl || "https://cloud.langfuse.com"); | |||
| this.flushAt = options?.flushAt ? Math.max(options?.flushAt, 1) : 1; | |||
| this.flushAt = options?.flushAt ? Math.max(options?.flushAt, 1) : 20; | |||
There was a problem hiding this comment.
default posthog behavior
There was a problem hiding this comment.
means we set a lower bound to 1, we could go lower
marcklingen
reviewed
Dec 13, 2023
langfuse-core/src/types.ts
Outdated
| observationId?: string | null; | ||
| comment?: string | null; | ||
| }; | ||
| export type UpdateLangfuseSpanBody = { |
There was a problem hiding this comment.
I'd only specify what is different from the create here. can they be merged?
langfuse-core/src/types.ts
Outdated
| version?: string | null; | ||
| statusMessage?: string | null; | ||
| }; | ||
| export type UpdateLangfuseGenerationBody = { |
| @@ -93,7 +104,7 @@ abstract class LangfuseCoreStateless { | |||
| this.publicKey = publicKey; | |||
| this.secretKey = secretKey; | |||
| this.baseUrl = removeTrailingSlash(options?.baseUrl || "https://cloud.langfuse.com"); | |||
| this.flushAt = options?.flushAt ? Math.max(options?.flushAt, 1) : 1; | |||
| this.flushAt = options?.flushAt ? Math.max(options?.flushAt, 1) : 20; | |||
There was a problem hiding this comment.
means we set a lower bound to 1, we could go lower
| } | ||
|
|
||
| // Flushes all events that are not yet sent to the server | ||
| // @returns {Promise[]} - list of promises for each item in the queue that is flushed | ||
| flush(): Promise<LangfuseFetchResponse>[] { | ||
| flush(callback?: (err?: any, data?: any) => void): void { |
There was a problem hiding this comment.
does it return promise or void?
| method: "POST", | ||
| body: payload, | ||
| }); | ||
| console.debug("Sending payload", payload); |
marcklingen
reviewed
Dec 16, 2023
| @@ -123,6 +124,7 @@ export class CallbackHandler extends BaseCallbackHandler { | |||
| async handleAgentAction(action: AgentAction, runId?: string, parentRunId?: string): Promise<void> { | |||
| try { | |||
| console.log("Agent action:", runId); | |||
|
|
|||
| this.langfuse.span({ | |||
There was a problem hiding this comment.
._updateSpan() to only set end but not start?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.