-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Database ValueFrom #14
base: main
Are you sure you want to change the base?
Conversation
b6f1438
to
bb7cf7f
Compare
bb7cf7f
to
2ee5b1b
Compare
3e1069c
to
b839a38
Compare
b839a38
to
3c9619a
Compare
Hey @japan4415, looks pretty cool, could you maybe also add the alternative way of using Source: https://langfuse.com/docs/deployment/self-host#configuring-environment-variables |
{{- if not .Values.langfuse.nextauth.secret.valueFrom }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one is not necessary with {{- if (not .Values.langfuse.nextauth.secret.valueFrom) }}
at the beginning of the file
labels: | ||
{{- include "langfuse.labels" . | nindent 4 }} | ||
data: | ||
{{- if not .Values.langfuse.nextauth.url.valueFrom }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not necessary with {{- if (not .Values.langfuse.nextauth.url.valueFrom) }}
(l.1)
{{- include "langfuse.labels" . | nindent 4 }} | ||
type: Opaque | ||
data: | ||
{{- if not .Values.langfuse.salt.valueFrom }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useless with {{- if (not .Values.langfuse.salt.valueFrom) }}
at the top?
@@ -1,6 +1,6 @@ | |||
apiVersion: v2 | |||
name: langfuse | |||
version: 0.2.1 | |||
version: 0.2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the changes, especially the non retro-compatibility introduced in values.yaml
and semver specs, it needs a major bump
Added comments. It seems to be a great addition but break retro-compatibility |
so sorry i missed notification from github |
Close #7
What I changed