Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default value in deprecated argument #1053

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add default value in deprecated argument #1053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions langfuse/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3170,22 +3170,22 @@ def flush(self, observation: StatefulClient, run_name: str):

def link(
self,
trace_or_observation: typing.Union[StatefulClient, str, None],
run_name: str,
run_metadata: Optional[Any] = None,
run_description: Optional[str] = None,
trace_id: Optional[str] = None,
observation_id: Optional[str] = None,
trace_or_observation: typing.Union[StatefulClient, str, None] = None,
):
"""Link the dataset item to observation within a specific dataset run. Creates a dataset run item.

Args:
trace_or_observation (Union[StatefulClient, str, None]): The trace or observation object to link. Deprecated: can also be an observation ID.
run_name (str): The name of the dataset run.
run_metadata (Optional[Any]): Additional metadata to include in dataset run.
run_description (Optional[str]): Description of the dataset run.
trace_id (Optional[str]): The trace ID to link to the dataset item. Set trace_or_observation to None if trace_id is provided.
observation_id (Optional[str]): The observation ID to link to the dataset item (optional). Set trace_or_observation to None if trace_id is provided.
trace_or_observation (Union[StatefulClient, str, None]): The trace or observation object to link. Deprecated: can also be an observation ID.
"""
parsed_trace_id: str = None
parsed_observation_id: str = None
Expand Down