Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extend coverage of API #827

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

feat: extend coverage of API #827

wants to merge 43 commits into from

Conversation

RichardKruemmel
Copy link
Contributor

@RichardKruemmel RichardKruemmel commented Aug 1, 2024 •
edited
Loading

  • fetch_scores
  • fetch_promtps
  • get_datasets
  • get_dataset_items
  • fetch_score

@RichardKruemmel RichardKruemmel self-assigned this Aug 1, 2024
@RichardKruemmel
feat: update fetch_scores method in Langfuse client
5f1e761
@RichardKruemmel
feat: update fetch_scores method in Langfuse client
e092a83
@RichardKruemmel
feat: add list method to ScoreClient
4983e43
@RichardKruemmel
fix: fix assertion order in test_fetch_scores
39f96a0
@RichardKruemmel
feat: add fetch_sessions method to Langfuse client
7ec1368
@RichardKruemmel
feat: add test_fetch_sessions to Langfuse client
c99055d
@RichardKruemmel
feat: refactor fetch_sessions method in Langfuse client
62baa1a
@RichardKruemmel
feat: add FetchPromptsResponse class and fetch_prompts method to Lang…
c5c2d5d 
…fuse client
@RichardKruemmel
feat: add test_fetch_prompts to Langfuse client
30073ed
@RichardKruemmel
refactor: remove unnecessary blank lines in Langfuse client
1997259
@RichardKruemmel
refactor: remove unnecessary blank lines in Langfuse client
fe7c4c6
@RichardKruemmel
refactor: remove unnecessary blank lines in Langfuse client
42694c4
@RichardKruemmel
refactor: update Langfuse client's get_prompts method parameters
b53ac5e
@RichardKruemmel
refactor: remove unnecessary blank lines in Langfuse client
9a410ae
marcklingen
marcklingen reviewed Aug 1, 2024
View reviewed changes
langfuse/api/resources/score/client.py Outdated Show resolved Hide resolved
tests/test_core_sdk.py Show resolved Hide resolved
tests/test_core_sdk.py Outdated Show resolved Hide resolved
@RichardKruemmel
refactor: add user_id and name parameters to Langfuse client's fetch_…
50ad9d5 
…scores method
@RichardKruemmel
refactor: update Langfuse client's list method parameters
71452dc
@RichardKruemmel
refactor: create multiple versions of a prompt in Langfuse client
c13f56a
@RichardKruemmel
refactor: update Langfuse client's fetch_scores method parameters
400ffea
@RichardKruemmel
refactor: update Langfuse client's fetch_scores method parameters
a0b41da
@RichardKruemmel
refactor: update Langfuse client's fetch_scores method parameters
a88b648
@RichardKruemmel
refactor: Update Langfuse client's fetch_scores method parameters
c5c216c
@RichardKruemmel
refactor: Update Langfuse client's fetch_scores method parameters
49cb6c6
@RichardKruemmel
refactor: Update Langfuse client's fetch_scores method parameters
e8da5e1
@RichardKruemmel
refactor: Update Langfuse client's fetch_scores method parameters
7c58106
@RichardKruemmel
refactor: Update Langfuse client's fetch_scores method parameters
2fb6325
@RichardKruemmel
refactor: Update Langfuse client's fetch_prompts method to fetch a sp…
410bd7a 
…ecific prompt by name
@RichardKruemmel
refactor: Update Langfuse client's fetch_prompts method to fetch a sp…
e4a342e 
…ecific prompt by name
@RichardKruemmel
refactor: Add methods to Langfuse client for retrieving datasets and …
4f74d31 
…dataset items
@RichardKruemmel
refactor: Add methods to Langfuse client for retrieving datasets and …
4b04131 
…dataset items
@RichardKruemmel
refactor: Update Langfuse client's fetch_scores method parameters
807ec4a
@RichardKruemmel
refactor: Add tests for retrieving dataset items and datasets
55a7bc3
@RichardKruemmel
refactor: Update Langfuse client's fetch_datasets method to handle pa…
3c1dc9b 
…gination
@RichardKruemmel
refactor: Update Langfuse client's fetch_datasets method to handle pa…
2ecaecc 
…gination
@RichardKruemmel
refactor: Update Langfuse client's fetch_datasets method to handle pa…
412ea05 
…gination
@RichardKruemmel
refactor: Update Langfuse client's fetch_score method to fetch a spec…
d1509d8 
…ific score by id
@RichardKruemmel
refactor: Update Langfuse client's fetch_score method to fetch a spec…
cd90b20 
…ific score by id
@RichardKruemmel
Refactor Langfuse client's fetch_score method to return specific scor…
49bde62 
…e by id
@RichardKruemmel RichardKruemmel marked this pull request as ready for review August 2, 2024 18:03
greptile-apps[bot]
greptile-apps bot reviewed Aug 2, 2024
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: Experimental PR review

PR Summary

The pull request extends the Langfuse API coverage by adding new methods for fetching scores, prompts, and datasets, and updating the linking of dataset items.

  • Added fetch_score, fetch_scores, fetch_prompts, get_datasets, and get_dataset_items methods in langfuse/client.py.
  • Updated link method in DatasetItemClient to handle various input types.
  • Added new test cases in tests/test_core_sdk.py to validate the new API endpoints and ensure correct data retrieval.

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

tests/test_core_sdk.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@marcklingen marcklingen Awaiting requested review from marcklingen

Assignees

@RichardKruemmel RichardKruemmel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RichardKruemmel @marcklingen