chore: upgrade fern #901
Open
chore: upgrade fern #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
This pull request upgrades the Fern-generated code in the langfuse-python repository, focusing on improving compatibility with both Pydantic v1 and v2 while enhancing overall functionality and type safety.
- Introduced AsyncFernLangfuse and FernLangfuse classes in client.py, providing both synchronous and asynchronous interfaces for the Langfuse API
- Added new serialization module (serialization.py) for handling type annotations and field metadata, improving type handling across the SDK
- Implemented a new query encoding mechanism in query_encoder.py to flatten and encode complex query structures for API requests
- Significantly refactored http_client.py to include robust error handling, retry logic, and support for additional request options
- Updated multiple resource type files (e.g., base_score.py, dataset.py) to use UniversalBaseModel, ensuring compatibility with both Pydantic versions
30 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
Comment on lines
+14
to
+18
| input: typing.Optional[typing.Optional[typing.Any]] = None | ||
| expected_output: typing.Optional[typing.Optional[typing.Any]] = pydantic.Field( | ||
| alias="expectedOutput", default=None | ||
| ) | ||
| metadata: typing.Optional[typing.Any] = None | ||
| source_trace_id: typing.Optional[str] = pydantic_v1.Field( | ||
| metadata: typing.Optional[typing.Optional[typing.Any]] = None |
There was a problem hiding this comment.
logic: Double Optional wrapping for 'input', 'expected_output', and 'metadata' fields. This might be unintentional and could lead to unexpected behavior.
| return active() | ||
| if self is DatasetStatus.ARCHIVED: | ||
| return archived() | ||
| DatasetStatus = typing.Union[typing.Literal["ACTIVE", "ARCHIVED"], typing.Any] |
There was a problem hiding this comment.
logic: Removal of visit method may break existing code that relies on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.