Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues #10055 #10643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

liuhaoran1212
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

fix the following issues: In a multi-round conversation, the current design of dify is that when the user passes the conversation_id parameter to the interface, the value of inputs can only be the value of inputs when the conversation is created.

Fixes #10055

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 13, 2024
@crazywoola
Copy link
Member

See this as well #7955

@liuzixiao666
Copy link

Does this version take effect on 0.11.0?

@liuzixiao666
Copy link

Does this version take effect on 0.11.0?

It didn't take effect, I just tried it

@crazywoola
Copy link
Member

Does this version take effect on 0.11.0?

It didn't take effect, I just tried it

No I mean, this is still under discussion, we haven't decided it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
3 participants