Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with using an JSON object with single quote in a string when testing API tools. #10735

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix issue with using an JSON object with single quote in a string when testing API tools. #10735

wants to merge 1 commit into from
+7 −5

Conversation

weimzh
Copy link

@weimzh weimzh commented Nov 15, 2024 •
edited
Loading

Summary

Fix issue with using an JSON object with single quote in a string when testing API tools.

Simply replacing the single quote with double quote will cause issue if some string in the JSON object contains single quotes. This fixes the issue.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 15, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 15, 2024
@weimzh weimzh changed the title Fix issue when using an JSON object with single quote in a string. Fix issue when using an JSON object with single quote in a string when testing API tools. Nov 15, 2024
@weimzh weimzh changed the title Fix issue when using an JSON object with single quote in a string when testing API tools. Fix issue with using an JSON object with single quote in a string when testing API tools. Nov 15, 2024
@weimzh
Fix issue with using an JSON object with single quote in a string whe…
5c5483a 
…n testing API tools.

Simply replacing the single quote with double quote will cause issue if some string in the JSON object contains single quotes.  This fixes the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🐞 bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@weimzh