Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade for webpack 4 #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Upgrade for webpack 4 #38

wants to merge 4 commits into from

Conversation

GeorgeLung
Copy link

@GeorgeLung GeorgeLung commented Mar 15, 2018

Made changes for plugin to be compatible with webpack v4

@codecov-io
Copy link

codecov-io commented Mar 15, 2018

Codecov Report

Merging #38 into master will decrease coverage by 7.61%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage    93.1%   85.48%   -7.62%     
==========================================
  Files           1        1              
  Lines          58       62       +4     
==========================================
- Hits           54       53       -1     
- Misses          4        9       +5
Impacted Files Coverage Δ
index.js 85.48% <93.75%> (-7.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8bc695...13e37bd. Read the comment docs.

@Reptarsrage
Copy link

Can I help get this merged? It's been open for two months O_o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants