-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt] Removed "temp_off" and add APs to rule ID:CARRO_AUTOMOVEL_VEICULO #11279
Conversation
WalkthroughThis pull request updates a rule in the Portuguese language module. It removes the Changes
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml (1)
3718-3736
: Antipattern Additions for Rule RefinementThe newly added
<antipattern>
elements provide detailed token sequences and examples to explicitly exclude certain phrases from triggering this rule. Each antipattern is defined with clear attributes (likecase_sensitive
andregexp
) and includes contextual examples. Please verify that the token ordering and attribute usage precisely match the intended language patterns, and ensure that these examples will comprehensively cover cases in production.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml (1)
3717-3717
: Rule Activation Update: Removal of thedefault='temp_off'
AttributeThe removal of the
default='temp_off'
attribute means the rule will now be active by default. This aligns with the PR objective of refining the rule by explicitly controlling its activation via antipatterns rather than disabling it by default.
Removed "temp_off" and added antipatterns.
Summary by CodeRabbit
New Features
Refactor