Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt-PT] Improved both .AFF files for AO45 and AO90 #13

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

marcoagpinto
Copy link
Member

Heya, @susanaboatto and @p-goulart

Like I said yesterday, I will do this task bit by bit to make sure I won't screw up.

So, here is an improvement for verb forms of the kind:

ama-a
ama-as
ama-lhe
ama-lhes
ama-me
ama-nos
ama-o
ama-os
ama-se
ama-se-lhe
ama-se-lhes
ama-te
ama-vos

NEW WORDS (AO45):
3.PTPT_45_new_verbs.txt

NEW WORDS (AO90):
6.PTPT_90_new_verbs.txt

PS→ Moments ago I forgot to create a Pull Request, so in the Git software I selected to amend it and repulled it.

@marcoagpinto marcoagpinto added the enhancement New feature or request label Jan 30, 2024
@p-goulart
Copy link
Collaborator

@marcoagpinto , for the time being, can you work off tagging/clitics instead of main? That's the branch where we're adding the new tokenisation logic. I'll change the base of this PR.

@p-goulart p-goulart changed the base branch from main to tagging/clitics January 30, 2024 08:58
@p-goulart p-goulart merged commit 62cdfe1 into tagging/clitics Jan 30, 2024
0 of 2 checks passed
@p-goulart p-goulart deleted the lt_marcoagpinto_20240130_0637 branch January 30, 2024 09:05
@marcoagpinto
Copy link
Member Author

@p-goulart

Ahhhh… Heya,

How do I work on /clitics?

I have the repository in a folder and I search for 45.aff, and it shows a folder from where I get/commit the .AFFs.

@p-goulart
Copy link
Collaborator

Instead of checking out the main branch, checkout tagging/clitics. When creating your new branch, make sure it's based on tagging/clitics.

@marcoagpinto
Copy link
Member Author

Instead of checking out the main branch, checkout tagging/clitics. When creating your new branch, make sure it's based on tagging/clitics.

Ahhhhh… thanks!

I will try to check out that instead of the main.

@marcoagpinto
Copy link
Member Author

@p-goulart @susanaboatto @jaumeortola

HELP!!!!!

Screenshot 2024-01-30 183845

@susanaboatto
Copy link
Collaborator

@marcoagpinto you don't need to clone it again if you already have the portuguese-pos-dict repo available. All you need to do is look for the tagging/clitics branch under the repo's branches, as you do with any of your other branches. Try updating the project first if you can't find it 😉
image

@marcoagpinto
Copy link
Member Author

Ahhhh… thanks, @susanaboatto , I will try tonight.

My idea of copying rules from the pt-BR into the pt-PT worked fine, just like I expected.

All I have to do is to change the flags names and numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants