Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt-PT] Added words to both dictionaries (.dic) #36

Merged
merged 3 commits into from
May 2, 2024

Conversation

marcoagpinto
Copy link
Member

Heya, @susanaboatto and @p-goulart ,

I have added some words to pt-PT dictionaries that were missing.

On Sunday, I will try to add the morphological information.

@marcoagpinto marcoagpinto added the enhancement New feature or request label Apr 27, 2024
@marcoagpinto
Copy link
Member Author

@p-goulart

I have added some words and their morphological information.

I am a lazy arse, so I didn't read the documentation and tried to mimic what was already in the files.

I had problems with the adjectives (so I didn't add any), for example, I am not sure how to use singular and plural ones:

psicossexual
psicossexuais

and issues trying to create the "core" of words.

I will try to read the documentation in the coming days.

These additions I have done were the ones possible without the need for documentation.

Copy link
Collaborator

@p-goulart p-goulart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

but it's probably good practice to update also the number of words at the top of the Hunspell .dic files; not a biggie, we can still accept.

@@ -31750,6 +31750,7 @@ diferencial=MF;src: LT;
diferenciação [pl. diferenciações]=F;src: LT;
diferendo=M;src: LT;
diferença=F;src: LT;
diferençazinha [pl. diferençazinhas]=F;src: LT;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason adding the explicit plural here was necessary? For regular plurals it's generally not needed.

@@ -3810,6 +3810,7 @@ Champalimaud Champalimaud NPCS000
Chamusca Chamusca NPCSG00
ChanServ ChanServ NPMS000
Chancelaria Chancelaria NPCSG00
Chandler Chandler NPMS000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chandler is a surname; as such, I'd prefer to make it N rather than M.

psicossexual/p
premia��o/p
apuradinho/pf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge issue, but you can prob. just use the diminutive affix flag on the original entry in many of these cases.

@p-goulart
Copy link
Collaborator

Sorry about all the pings. Just realised resolving conflicts in the GitHub UI is a bad idea, as it converts files to UTF-8. Lessons learnt!

@p-goulart p-goulart force-pushed the lt_marcoagpinto_20240427_1828 branch from 7d6dc27 to 60c26cb Compare April 30, 2024 16:59
@p-goulart p-goulart merged commit 5a9d600 into main May 2, 2024
5 checks passed
@p-goulart p-goulart deleted the lt_marcoagpinto_20240427_1828 branch May 2, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants