Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for JuMP Direct Mode #879

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Add test for JuMP Direct Mode #879

merged 1 commit into from
Aug 13, 2023

Conversation

ccoffrin
Copy link
Member

@odow does this look suitable for a direct mode test?

Closes #275

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #879 (26cc8e9) into master (46ec8cd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   93.87%   93.87%           
=======================================
  Files          43       43           
  Lines        9973     9973           
=======================================
  Hits         9362     9362           
  Misses        611      611           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ec8cd...26cc8e9. Read the comment docs.

@odow
Copy link
Collaborator

odow commented Aug 13, 2023

Yip. I don't think you need to do anything internally.

@odow
Copy link
Collaborator

odow commented Aug 13, 2023

Maybe people haven't complained because they've just been doing this already.

@ccoffrin
Copy link
Member Author

Yes, indeed! jump_model is not a well known feature but I can imagine such advanced users may have found it.

@ccoffrin ccoffrin merged commit a7c6017 into master Aug 13, 2023
15 checks passed
@ccoffrin ccoffrin deleted the direct-mode-test branch August 13, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JuMP Direct Mode
2 participants