Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in calc_theta_delta_bounds #908

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Conversation

ccoffrin
Copy link
Member

closes #907

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 94.19%. Comparing base (8a1dc36) to head (80537f9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
- Coverage   94.22%   94.19%   -0.03%     
==========================================
  Files          43       43              
  Lines        9612     9618       +6     
==========================================
+ Hits         9057     9060       +3     
- Misses        555      558       +3     
Files Coverage Δ
src/core/data.jl 91.98% <71.42%> (-0.10%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1dc36...80537f9. Read the comment docs.

@ccoffrin ccoffrin merged commit 57d382d into master Mar 16, 2024
13 of 15 checks passed
@ccoffrin ccoffrin deleted the fix-theta-delta-bounds branch March 16, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential bug in on_off constraints for dcp.jl
1 participant