Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slurmrestd version function #953

Merged
merged 13 commits into from
Dec 3, 2024
Merged

Fix slurmrestd version function #953

merged 13 commits into from
Dec 3, 2024

Conversation

rstyd
Copy link
Collaborator

@rstyd rstyd commented Nov 4, 2024

This PR fixes the slurmrestd inference function. It also adds a debug message that states what version it finds.

Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rstyd Should there be a fix for the configuration file?

@pagrubel pagrubel added the WIP Work in progress label Nov 12, 2024
@pagrubel
Copy link
Collaborator

Please remove api version from config and use whatever is installed.

@rstyd rstyd removed the WIP Work in progress label Dec 2, 2024
@rstyd rstyd requested a review from pagrubel December 2, 2024 23:15
@pagrubel
Copy link
Collaborator

pagrubel commented Dec 3, 2024

I tried this out with and without slurmrestd and it seems to work well. I haven't reviewed the changes yet.

Copy link
Collaborator

@kchilleri kchilleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also works for me + I can find the openapi_version in the beeflow logs.

@rstyd rstyd merged commit db83871 into develop Dec 3, 2024
12 checks passed
@pagrubel pagrubel deleted the fix_slurmrestd_infer branch December 3, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants