Derived test module reloads and cleanup #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdmullen
changed the title
adamdempsey90
requested changes
Nov 21, 2024
pdmullen
changed the title
brryan
reviewed
Nov 21, 2024
pdmullen
changed the title
1 task
brryan
reviewed
Nov 25, 2024
brryan
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Apart from the --cwd option to guard against surprises with searching for local executables which I would like to see added, LGTM, approving now, thanks for all this typing @pdmullen, sorry I broke your workflow with --oversubscribe before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Moderate cleanup of CI and fixes regression execution on Macs.
Description of Changes
importlib(such that we will not worry about future derived tests having shared states dependent on order of execution).librebound.so.Checklist