Skip to content

Commit

Permalink
update argument for bueno plugin init
Browse files Browse the repository at this point in the history
  • Loading branch information
qwofford committed Jun 24, 2023
1 parent c8d495c commit 349706c
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
12 changes: 9 additions & 3 deletions dsi/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,16 +122,22 @@ def transload(self, **kwargs):
self.transload_lock=True


def query(self):
"""Query is the user-facing query interface to a DSI Core Terminal."""
def user_handler(self, **kwargs):
"""
The user_handler prepares a human/machine interface.
A Driver implements the user_handler experience, defining how the user interacts with the
`self.active_metadata` currently loaded in the DSI Core Terminal.
"""
pass

def artifact_handler(self,interaction_type,**kwargs):
"""
Store or retrieve using all loaded DSI Drivers with back-end functionality.
A DSI Core Terminal may load zero or more Drivers with back-end storage functionality.
Calling store will execute all back-end functionality currently loaded.
Calling artifact_handler will execute all back-end functionality currently loaded, given
the provided ``interaction_type``.
"""
if interaction_type not in self.VALID_ARTIFACT_INTERACTION_TYPES:
print('Hint: Did you declare your artifact interaction type in the Terminal Global vars?')
Expand Down
2 changes: 1 addition & 1 deletion dsi/drivers/filesystem.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def get_artifacts(self, query):
pass

class Filesystem(Driver):
git_commit_sha='b05404e70fab9e2f90f6fb47b234fb18bbe547e5'
git_commit_sha='c8d495cd58ac9abf9f43f5c89f1ea84a89699bf4'
# Declare named types
DOUBLE = "DOUBLE"
STRING = "VARCHAR"
Expand Down
2 changes: 1 addition & 1 deletion dsi/plugins/metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def add_to_output(self, path):

class StructuredMetadata(Plugin):
""" plugin superclass that provides handy methods for structured data """
git_commit_sha='b05404e70fab9e2f90f6fb47b234fb18bbe547e5'
git_commit_sha='c8d495cd58ac9abf9f43f5c89f1ea84a89699bf4'

def __init__(self):
"""
Expand Down
2 changes: 1 addition & 1 deletion dsi/plugins/tests/test_env.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def test_envprov_plugin_adds_rows():
def test_bueno_plugin_type():
plug = Bueno()
path = '/'.join([get_git_root('.'),'dsi/data','bueno.data'])
plug.add_row(path)
plug.add_row(filename=path)
assert type(plug.output_collector) == collections.OrderedDict

def test_bueno_plugin_adds_rows():
Expand Down

0 comments on commit 349706c

Please sign in to comment.