Update Optimizer #82
Merged
Update Optimizer #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torch also a hippynn wrapper under __init__.py
update HippyNNBatchOptimizer for pull request
Merge changes from current official development branch to add triton updates Note that this will overwrite local changes to optimizers, need to checkout later to recover them Merge remote-tracking branch 'dev0809/development' into development
|
Hi @amateurcat, I updated many things in terms of format and naming and location, but the core code has not been touched. I also added some features for more automatically searching for the right nodes in the supplied model graph. Are there any other items before we are ready to take this PR? |
|
Hi @lubbersnick , yes, it is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add batch BFGS implementations
Update hippynn wrapper, now it can dump trajectories
Add test cases