Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Call Python Explicitly #4

Merged
merged 1 commit into from
May 7, 2020
Merged

Don't Call Python Explicitly #4

merged 1 commit into from
May 7, 2020

Conversation

Yurlungur
Copy link
Collaborator

Solves issue #2 and replaces call["python",...]) with call([sys.executable,...]). Issue was caught by @kinchb who found that if multiple versions of python are installed, it can cause problems.

@Yurlungur Yurlungur self-assigned this May 7, 2020
@Yurlungur Yurlungur requested a review from kinchb May 7, 2020 21:26
@Yurlungur Yurlungur added bug Something isn't working good first issue Good for newcomers labels May 7, 2020
kinchb
kinchb approved these changes May 7, 2020
View reviewed changes
Copy link
Collaborator

@kinchb kinchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Yurlungur Yurlungur merged commit cc1b175 into master May 7, 2020
@Yurlungur
Copy link
Collaborator Author

Thanks. Merged.

@Yurlungur Yurlungur mentioned this pull request May 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinchb kinchb kinchb approved these changes

Assignees

@Yurlungur Yurlungur

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yurlungur @kinchb @jonahm-LANL