Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation to PTE solver and expose runtime parameters #425

Merged
merged 9 commits into from
Oct 15, 2024

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

In riot we are looking into some load balancing questions and performance of the PTE solver. To support this, I make the following changes to the PTE solver:

  • I expose the mix_params namespace as a container struct that can be set at runtime
  • I modify the return value of the PTESolver function to include some instrumentation, such as the number of iterations the solver took.
  • I expose a verbosity parameter to suppress warnings if we want.
  • I clean up the documentation and variable names a bit.

I also split up the modifier tests to help with compile times and do a small bug fix which was causing problems with the newest version of gcc.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@Yurlungur Yurlungur added the clean-up Changes that don't affect code execution but make the code cleaner label Oct 15, 2024
@Yurlungur Yurlungur self-assigned this Oct 15, 2024
@Yurlungur Yurlungur linked an issue Oct 15, 2024 that may be closed by this pull request
Copy link
Collaborator

@jhp-lanl jhp-lanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The majority of the DIFFs are just size_t vs int or adding params. it seems. I've commented on anything else that I didn't understand.

Thanks a bunch for these fixes! They are most welcome!

doc/sphinx/src/using-closures.rst Outdated Show resolved Hide resolved
doc/sphinx/src/using-closures.rst Outdated Show resolved Hide resolved
singularity-eos/closure/mixed_cell_models.hpp Show resolved Hide resolved
singularity-eos/eos/eos_base.hpp Show resolved Hide resolved
@Yurlungur Yurlungur merged commit 47e0076 into main Oct 15, 2024
6 checks passed
@Yurlungur Yurlungur deleted the jmm/pte-instrumentation branch October 15, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up Changes that don't affect code execution but make the code cleaner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Tguess in PTE solver and document temp[0] usage
4 participants