-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instrumentation to PTE solver and expose runtime parameters #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurlungur
added
the
clean-up
Changes that don't affect code execution but make the code cleaner
label
Oct 15, 2024
…-eos into jmm/pte-instrumentation
jhp-lanl
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The majority of the DIFFs are just size_t
vs int
or adding params.
it seems. I've commented on anything else that I didn't understand.
Thanks a bunch for these fixes! They are most welcome!
Co-authored-by: Jeff Peterson <[email protected]>
Co-authored-by: Jeff Peterson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In riot we are looking into some load balancing questions and performance of the PTE solver. To support this, I make the following changes to the PTE solver:
mix_params
namespace as a container struct that can be set at runtimePTESolver
function to include some instrumentation, such as the number of iterations the solver took.I also split up the modifier tests to help with compile times and do a small bug fix which was causing problems with the newest version of gcc.
PR Checklist
make format
command after configuring withcmake
.If preparing for a new release, in addition please check the following:
when='@main'
dependencies are updated to the release version in the package.py