Add template args to DataBox
#47
Conversation
|
I'm not sure what's going on with the CI here |
I bet the VM changed. Let me see if I can fix it |
|
@brryan I fixed the CI--needed to update the workflows clone call. Some bits have rotted with the tests, though, in particular with ports-of-call. |
|
Thanks @Yurlungur! Can I go ahead and merge even with the |
|
I haven't figure it out. Something screwy with the cmake. I may need @mauneyc-LANL 's help |
|
Can you clarify is this |
|
Looking over |
There were a number of issues. With an update to |
|
OK I think I fixed it. @brryan @cmauney @mauneyc-LANL please take a look. |
| @@ -64,9 +66,22 @@ if (HDF5_FOUND) | |||
| else() | |||
| message("MPI::MPI_CXX provided by parent package") | |||
| endif() | |||
| else() | |||
| message(status "HDF5 is not parallel") | |||
There was a problem hiding this comment.
case-senstivity is weird in CMake but I think in this case it's insensitive
There was a problem hiding this comment.
I briefly googled this out of curiosity and the first example was message(status of all things and apparently it actually does matter in this case: https://stackoverflow.com/a/35034125
There was a problem hiding this comment.
It looks like that stack overflow is about the case of the thing the message is about, not the STATUS flag? The rest of the code is using lower-case, which is why I kept doing it
| @@ -186,8 +186,8 @@ class MeanOpacity { | |||
| PORTABLE_INLINE_FUNCTION Real fromLog_(const Real lx) const { | |||
| return std::pow(10., lx); | |||
| } | |||
| Spiner::DataBox lkappaPlanck_; | |||
| Spiner::DataBox lkappaRosseland_; | |||
| Spiner::DataBox<Real> lkappaPlanck_; | |||
There was a problem hiding this comment.
Thanks for fixing the mean_s_opacity functions as well -- should we move these original changes to the using Databox = pattern you have elsewhere for consistency? I can do this if you want to hand the PR back to me
There was a problem hiding this comment.
Sure, that sounds good. Thanks!
|
I still haven't wrapped my head around the original issue, but I don't see any problems with changes.If it works g2g |
|
@brryan if you wanna change the |
We started getting compiler errors from
DataBoxdue to lack of template argument. I added<Real>to the neutrino and photonDataBoxes used by the mean opacity functions.