[NASA] Add Automatic Cleaning mode for Samsung AC - Deprecated due to issues #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it dries all moisture in the interior hygienically.
- Added the 'automatic_cleaning' feature to the Samsung AC integration. - This mode ensures hygienic drying of all moisture in the indoor unit after the cooling process is completed.
lanwin
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Thank you for your pullrequest! There are a few things to change.
- First there is an unresolved conflict
- Then can you please check the indentation (you can see it in the pullrequest "Files changed" tab.
- Both log options should start with debug_ like the other ones.
- It seems log_messages isnt used anywhere
|
Also the source in the example.yaml points to the wrong repo :D |
…ented debug_log_messages functionality, and corrected repository source address in the YAML file.
omerfaruk-aran
force-pushed
the
new_test
branch
from
15f47fd
to
74fb700
Compare
omerfaruk-aran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the automatic cleaning mode to the Samsung AC integration.
- Resolves #121
The automatic cleaning mode ensures hygienic drying of all moisture in the indoor unit after the cooling process is completed.
Additional Features:
Added two new parameters: log_messages and log_undefined_messages.
log_messages: Enables logging of messages. When set to true, all defined log messages will be recorded.
log_undefined_messages: Allows logging of undefined messages. When set to true, any undefined messages will be logged for further analysis.
If both log_messages and log_undefined_messages are set to false, you will only see logs for the functions that you execute through SmartThings. This approach allows you to easily add new features without cluttering the logs with unnecessary information.