Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AvatarImgで括弧や空白が入っている文字列でも正しく表示できるように修正 #282

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

yuichkun
Copy link
Contributor

@yuichkun yuichkun commented Nov 12, 2024

Issue

closes https://github.com/lapras-inc/scouty/issues/26171

動作確認

storybookで確認

before

Screenshot 2024-11-12 at 12 49 45

after

Screenshot 2024-11-12 at 12 49 19

@yuichkun yuichkun self-assigned this Nov 12, 2024
@yuichkun yuichkun requested a review from kawamataryo November 12, 2024 03:59
Copy link
Member

@kawamataryo kawamataryo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!!
Andy Dwyer Excited

@kawamataryo kawamataryo merged commit c633001 into master Nov 12, 2024
3 of 4 checks passed
@kawamataryo kawamataryo deleted the 26171/fix/avatar-img-escape-url branch November 12, 2024 04:01
@scoutea scoutea mentioned this pull request Nov 12, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants