Enhance/package install method #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jespada please be careful about tests :) |
|
Please fix your license - "all rights reserved" is not ok if the rest of the project is apache license. |
|
Thanks for the license fix :) Zabbix provides RPMs at repo.zabbix.com - could we not make the agent install default to install from there and provide mechanisms for overriding. |
|
@lflux yeah I guess I can add a recipe (zabbix::_repos) to this cookbook and set as a default in attributes so if you don't want that in your wrapper you can override that one, what do you think? |
|
That sounds like a good approach. |
|
👍 |
|
Guys, any update on this? |
Prevent changing /var/log and /var/run ownership and permissions
This reverts commit 7e5ce7e. The package `redhat-lsb` is needed to manage services, but there's not test checking this, so removing it let all tests pass, but made the cookbook fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this PR is to enable the installation of zabbix from a custom repo, so you can use a wrapper-zabbix cookbook and get the package form your internal repos or any other repo you want.
Lets talk, then I can add some spec tests